lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops
From
Date
On 7/21/21 12:00 AM, Pierre-Louis Bossart wrote:
>
>> diff --git a/sound/soc/amd/vangogh/acp5x.h b/sound/soc/amd/vangogh/acp5x.h
>> index 2300e63534e7..c94ed8795b9c 100644
>> --- a/sound/soc/amd/vangogh/acp5x.h
>> +++ b/sound/soc/amd/vangogh/acp5x.h
>> @@ -74,9 +74,20 @@
>> #define I2S_MASTER_MODE_ENABLE 0x01
>> #define I2S_MASTER_MODE_DISABLE 0x00
>>
>> +#define SLOT_WIDTH_8 0x08
>> +#define SLOT_WIDTH_16 0x10
>> +#define SLOT_WIDTH_24 0x18
>> +#define SLOT_WIDTH_32 0x20
>
> nit-pick: it's not incorrect but is the hex notation necessary?

Will fix it and post the new version

>
>> +#define TDM_ENABLE 1
>> +#define TDM_DISABLE 0
>> +#define ACP5x_ITER_IRER_SAMP_LEN_MASK 0x38

\
 
 \ /
  Last update: 2021-07-21 00:52    [W:0.046 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site