Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 20 Jul 2021 17:52:02 +0300 | Subject | Re: [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780 |
| |
On Tue, Jul 20, 2021 at 5:33 PM Miclaus, Antoniu <Antoniu.Miclaus@analog.com> wrote: > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > Sent: Tuesday, July 20, 2021 5:08 PM > > On Tue, Jul 20, 2021 at 4:17 PM Miclaus, Antoniu > > <Antoniu.Miclaus@analog.com> wrote: > > > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > > > Sent: Friday, July 16, 2021 5:53 PM > > > > On Fri, Jul 16, 2021 at 2:43 PM Antoniu Miclaus > > > > <antoniu.miclaus@analog.com> wrote:
...
> > > > First question is why not to use the regmap API (I have heard it has > > > > gained support of 17 bit)? > > > > > > Initially that was the plan, but after this patch: > > > > > https://urldefense.com/v3/__https://github.com/torvalds/linux/commit/41 > > 91f19792bf91267835eb090d970e9cd6277a65__;!!A3Ni8CS0y2Y!ptUV0YC2nfD > > 6AdH_y5U0ziyELl4B9pDL0ubkdpFHFtrFNE_NqUS_TWm_gE-SlHV315Ak$ > > > the custom write formats for regmap allow the read only via cached > > registers. > > > > > > Therefore, I preferred using spi transfers for write/read to/from the > > device. > > > > Not sure I follow you. That patch is upstream. Does it prevent you > > from switching to regmap SPI API? > > It does not prevent me from switching to regmap SPI API. > It will prevent me from using regmap_read to read directly from device. > https://github.com/torvalds/linux/commit/4191f19792bf91267835eb090d970e9cd6277a65#diff-3e0b7d2f0a55adb6573693a514cb8024a81a55da848cb22632ab5fd4dd6dd4e4R39
How? If it's the case it's a huge regression in the API and must be fixed ASAP.
-- With Best Regards, Andy Shevchenko
| |