lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets
> +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> +{
> + /*
> + * Simple invocations do not provide a calc_sets() callback. Call
> + * the generic one.
> + */
> + if (!affd->calc_sets)
> + default_calc_sets(affd, affvecs);
> + else
> + affd->calc_sets(affd, affvecs);

Nit: avoid pointless negations:

if (affd->calc_sets)
affd->calc_sets(affd, affvecs);
else
default_calc_sets(affd, affvecs);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2021-07-20 09:53    [W:0.089 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site