lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH V2 2/3] riscv: Add support for restartable sequence
    On Mon, Jul 19, 2021 at 10:43 PM Mathieu Desnoyers
    <mathieu.desnoyers@efficios.com> wrote:
    >
    > ----- On Mar 9, 2020, at 1:59 AM, Vincent Chen vincent.chen@sifive.com wrote:
    > [...]
    > > --- a/arch/riscv/kernel/signal.c
    > > +++ b/arch/riscv/kernel/signal.c
    > > @@ -234,6 +234,7 @@ static void handle_signal(struct ksignal *ksig, struct
    > > pt_regs *regs)
    > > sigset_t *oldset = sigmask_to_save();
    > > int ret;
    > >
    > > + rseq_signal_deliver(ksig, regs);
    > > /* Are we from a system call? */
    > > if (regs->cause == EXC_SYSCALL) {
    >
    > [...]
    >
    > As Al Viro pointed out on IRC, the rseq_signal_deliver() should go after syscall
    > restart handling, similarly to what is done on every other supported architecture.

    Thanks for the notification. I will adjust the porting and try to send
    the patch again for review.


    >
    > Note that there is already an upstream commit derived on this non-upstream patch:
    >
    > commit 9866d141a097 ("csky: Add support for restartable sequence")
    >
    > which is broken in the same way.
    >
    > I'm not sure why I was never CC'd on the csky patch. Considering that nobody
    > bothered to implement the rseq selftests for csky, I don't see how any of
    > this is tested. I would favor a revert of that commit until the testing glue
    > is contributed. Unfortunately, the csky commit has been upstream since v5.7.
    >
    > Thanks,
    >
    > Mathieu
    >
    >
    > --
    > Mathieu Desnoyers
    > EfficiOS Inc.
    > http://www.efficios.com

    \
     
     \ /
      Last update: 2021-07-21 05:22    [W:4.153 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site