Messages in this thread | | | From | Martin Blumenstingl <> | Date | Sat, 3 Jul 2021 00:57:57 +0200 | Subject | Re: [PATCH v3 2/3] clk: divider: Switch from .round_rate to .determine_rate by default |
| |
Hi Stephen,
On Fri, Jul 2, 2021 at 10:59 PM Stephen Boyd <sboyd@kernel.org> wrote: [...] > I'd prefer we leave round_rate assigned in clk_divider_ops and > clk_divider_ro_ops but then also assign the determine_rate function. We > have some duplication but that's OK. Then make individual patches to > migrate each driver over to the new clk op. I just sent a series with those changes: [0]
> We could stack a final patch on top to remove the round_rate function > from clk divider. Unfortunately, if some driver wants to use round_rate > then it will fail in interesting ways. Probably best to live with it > until we decide to drop round_rate entirely. Patches to convert all the > round_rate code over to determine_rate would be welcome in the meantime. For now I have omitted the patch to remove .round_rate from clk_divider_ops. Also I will start migrating .round_rate over to .determine_rate in drivers/clk/meson/ (as it's the only hardware with CCF support that I have).
Best regards, Martin
[0] https://patchwork.kernel.org/project/linux-clk/cover/20210702225145.2643303-1-martin.blumenstingl@googlemail.com/
| |