Messages in this thread | | | Subject | Re: [PATCH 3/3] mm: sparse: remove __section_nr() function | From | David Hildenbrand <> | Date | Fri, 2 Jul 2021 19:57:13 +0200 |
| |
On 02.07.21 14:18, Michal Hocko wrote: > On Fri 02-07-21 18:41:32, Ohhoon Kwon wrote: >> __section_nr() was used to convert struct mem_section * to section_nr. >> >> With CONFIG_SPARSEMEM_EXTREME enabled, however, __section_nr() can be >> costly since it iterates all section roots to check if the given >> mem_section is in its range. >> >> On the other hand, __nr_to_section() which converts section_nr to >> mem_section can be done in O(1). >> >> The only users of __section_nr() was section_mark_present() and >> find_memory_block(). >> >> Since I changed both functions to use section_nr directly in the >> preceeding patches, let's remove __section_nr() which has no users. >> >> Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com> > > I would go with a much shorter changelog. The function is not used > anymore so it can be simply dropped. > Acked-by: Michal Hocko <mhocko@suse.com>
Agreed, also avoid the use of "I" in patches.
Use something like
"As the last users of __section_nr() are gone, let's remove now unused __section_nr()."
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |