lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 013/315] ext4: cleanup in-core orphan list if ext4_truncate() failed to get a transaction handle
    Date
    From: Zhang Yi <yi.zhang@huawei.com>

    commit b9a037b7f3c401d3c63e0423e56aef606b1ffaaf upstream.

    In ext4_orphan_cleanup(), if ext4_truncate() failed to get a transaction
    handle, it didn't remove the inode from the in-core orphan list, which
    may probably trigger below error dump in ext4_destroy_inode() during the
    final iput() and could lead to memory corruption on the later orphan
    list changes.

    EXT4-fs (sda): Inode 6291467 (00000000b8247c67): orphan list check failed!
    00000000b8247c67: 0001f30a 00000004 00000000 00000023 ............#...
    00000000e24cde71: 00000006 014082a3 00000000 00000000 ......@.........
    0000000072c6a5ee: 00000000 00000000 00000000 00000000 ................
    ...

    This patch fix this by cleanup in-core orphan list manually if
    ext4_truncate() return error.

    Cc: stable@kernel.org
    Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20210507071904.160808-1-yi.zhang@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/super.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -2614,8 +2614,15 @@ static void ext4_orphan_cleanup(struct s
    inode_lock(inode);
    truncate_inode_pages(inode->i_mapping, inode->i_size);
    ret = ext4_truncate(inode);
    - if (ret)
    + if (ret) {
    + /*
    + * We need to clean up the in-core orphan list
    + * manually if ext4_truncate() failed to get a
    + * transaction handle.
    + */
    + ext4_orphan_del(NULL, inode);
    ext4_std_error(inode->i_sb, ret);
    + }
    inode_unlock(inode);
    nr_truncates++;
    } else {

    \
     
     \ /
      Last update: 2021-07-19 17:34    [W:4.527 / U:1.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site