Messages in this thread | | | Date | Mon, 19 Jul 2021 09:50:50 +0300 | From | Dan Carpenter <> | Subject | [ti:ti-rt-linux-5.10.y 6720/6782] drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'. |
| |
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y head: bee192299392dc41c94f4603968b7a3c02f17a1d commit: 80dac899053d08524a40f195905022bb08e6104c [6720/6782] media: entity: Move the pipeline from entity to pads config: i386-randconfig-m021-20210718 (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings: drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
vim +/ret +443 drivers/media/mc/mc-entity.c
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 406 __must_check int __media_pipeline_start(struct media_entity *entity, e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 407 struct media_pipeline *pipe) e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 408 { d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas 2015-08-19 409 struct media_device *mdev = entity->graph_obj.mdev; 20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 410 struct media_graph *graph = &pipe->graph; cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 411 struct media_pad *pad = entity->pads; cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 412 struct media_pad *pad_err = pad; 57208e5e25f263 drivers/media/media-entity.c Mauro Carvalho Chehab 2015-08-07 413 struct media_link *link; af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 414 int ret; e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 415 74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 416 if (!pipe->streaming_count++) { 20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 417 ret = media_graph_walk_init(&pipe->graph, mdev); 74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 418 if (ret) 74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 419 goto error_graph_walk_start; 106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 420 }
Not initialized on else path
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 421 cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 422 media_graph_walk_start(&pipe->graph, pad); cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 423 cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 424 while ((pad = media_graph_walk_next(graph))) { cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 425 struct media_entity *entity = pad->entity; 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 426 bool skip_validation = pad->pipe != NULL; 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 427 struct media_pad *iter; e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 428 ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 429 DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS); ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 430 DECLARE_BITMAP(has_no_links, MEDIA_ENTITY_MAX_PADS); af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 431 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 432 media_entity_for_each_pad(entity, iter) { 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 433 if (iter->pipe && iter->pipe != pipe) { 3eb87773dee633 drivers/media/media-entity.c Shuah Khan 2019-02-22 434 pr_err("Pipe active for %s. Can't start for %s\n", 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 435 entity->name, iter->entity->name); 8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 436 ret = -EBUSY; 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 437 } else { 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 438 iter->pipe = pipe; 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 439 } 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 440 iter->stream_count++; 8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 441 } 8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 442 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 @443 if (ret)
Only initialized on failure
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 444 goto error; af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 445 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 446 /* Already part of the pipeline, skip validation. */ 80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 447 if (skip_validation) af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 448 continue; af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 449 af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 450 if (!entity->ops || !entity->ops->link_validate) af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 451 continue; af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 452
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
| |