lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 048/188] crypto: ixp4xx - dma_unmap the correct address
    Date
    From: Corentin Labbe <clabbe@baylibre.com>

    [ Upstream commit 9395c58fdddd79cdd3882132cdd04e8ac7ad525f ]

    Testing ixp4xx_crypto with CONFIG_DMA_API_DEBUG lead to the following error:
    DMA-API: platform ixp4xx_crypto.0: device driver tries to free DMA memory it has not allocated [device address=0x0000000000000000] [size=24 bytes]

    This is due to dma_unmap using the wrong address.

    Fixes: 0d44dc59b2b4 ("crypto: ixp4xx - Fix handling of chained sg buffers")
    Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/ixp4xx_crypto.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
    index 13657105cfb9..8d0613170d57 100644
    --- a/drivers/crypto/ixp4xx_crypto.c
    +++ b/drivers/crypto/ixp4xx_crypto.c
    @@ -334,7 +334,7 @@ static void free_buf_chain(struct device *dev, struct buffer_desc *buf,u32 phys)

    buf1 = buf->next;
    phys1 = buf->phys_next;
    - dma_unmap_single(dev, buf->phys_next, buf->buf_len, buf->dir);
    + dma_unmap_single(dev, buf->phys_addr, buf->buf_len, buf->dir);
    dma_pool_free(buffer_pool, buf, phys);
    buf = buf1;
    phys = phys1;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 17:10    [W:5.921 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site