lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 5/6] media: dt-bindings: mt9p031: Convert bindings to yaml
Date
Hi Rob,

On Fri, 2021-07-16 at 13:23 -0600, Rob Herring wrote:
> On Wed, Jul 14, 2021 at 03:38:48PM +0200, Stefan Riedmueller wrote:
> > Convert mt9p031 sensor bindings to yaml schema. Also update the
> > MAINTAINERS entry.
> >
> > Although input-clock-frequency and pixel-clock-frequency have not been
> > definded as endpoint propierties in the textual bindings, the sensor
> > does parse them from the endpoint. Thus move these properties to the
> > endpoint in the new yaml bindings.
> >
> > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> > ---
> > .../bindings/media/i2c/aptina,mt9p031.yaml | 92 +++++++++++++++++++
> > .../devicetree/bindings/media/i2c/mt9p031.txt | 40 --------
> > MAINTAINERS | 1 +
> > 3 files changed, 93 insertions(+), 40 deletions(-)
> > create mode 100644
> > Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > delete mode 100644
> > Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > new file mode 100644
> > index 000000000000..1531ecd1ed95
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > @@ -0,0 +1,92 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9p031.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor
> > +
> > +maintainers:
> > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +description: |
> > + The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image
> > sensor
> > + with an active array size of 2592H x 1944V. It is programmable through
> > a
> > + simple two-wire serial interface.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - aptina,mt9p031
> > + - aptina,mt9p031m
> > +
> > + reg:
> > + description: I2C device address
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + maxItems: 1
> > + description: Chip reset GPIO
> > +
> > + port:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + additionalProperties: false
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + input-clock-frequency:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 6000000
> > + maximum: 96000000
> > + description: Input clock frequency
> > +
> > + pixel-clock-frequency:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + maximum: 96000000
> > + description: Target pixel clock frequency
> > +
> > + bus-type:
> > + const: 5
> > +
> > + bus-width:
> > + const: 12
>
> If there's only 1 possible setting for both of these, why do they need
> to be in DT?

My idea was to have them here as constraints in case someone wants to add them
to although there is no actual need to. That's why I added them optional. But
to be honest, I wasn't sure if that's the correct approach, so if you'd prefer
to drop them then it's fine with me.

Regards,
Stefan



>
> Rob
\
 
 \ /
  Last update: 2021-07-19 08:45    [W:0.040 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site