lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 055/188] media: tc358743: Fix error return code in tc358743_probe_of()
    Date
    From: Zhen Lei <thunder.leizhen@huawei.com>

    [ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ]

    When the CSI bps per lane is not in the valid range, an appropriate error
    code -EINVAL should be returned. However, we currently do not explicitly
    assign this error code to 'ret'. As a result, 0 was incorrectly returned.

    Fixes: 256148246852 ("[media] tc358743: support probe from device tree")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/tc358743.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
    index 1e95fdb61041..c3befb3f5dcd 100644
    --- a/drivers/media/i2c/tc358743.c
    +++ b/drivers/media/i2c/tc358743.c
    @@ -1761,6 +1761,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
    bps_pr_lane = 2 * endpoint->link_frequencies[0];
    if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) {
    dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane);
    + ret = -EINVAL;
    goto disable_clk;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 17:10    [W:4.175 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site