lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 025/188] seq_buf: Make trace_seq_putmem_hex() support data longer than 8
    Date
    From: Yun Zhou <yun.zhou@windriver.com>

    commit 6a2cbc58d6c9d90cd74288cc497c2b45815bc064 upstream.

    Since the raw memory 'data' does not go forward, it will dump repeated
    data if the data length is more than 8. If we want to dump longer data
    blocks, we need to repeatedly call macro SEQ_PUT_HEX_FIELD. I think it
    is a bit redundant, and multiple function calls also affect the performance.

    Link: https://lore.kernel.org/lkml/20210625122453.5e2fe304@oasis.local.home/
    Link: https://lkml.kernel.org/r/20210626032156.47889-2-yun.zhou@windriver.com

    Cc: stable@vger.kernel.org
    Fixes: 6d2289f3faa7 ("tracing: Make trace_seq_putmem_hex() more robust")
    Signed-off-by: Yun Zhou <yun.zhou@windriver.com>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    lib/seq_buf.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/lib/seq_buf.c
    +++ b/lib/seq_buf.c
    @@ -241,12 +241,14 @@ int seq_buf_putmem_hex(struct seq_buf *s
    break;

    /* j increments twice per loop */
    - len -= j / 2;
    hex[j++] = ' ';

    seq_buf_putmem(s, hex, j);
    if (seq_buf_has_overflowed(s))
    return -1;
    +
    + len -= start_len;
    + data += start_len;
    }
    return 0;
    }

    \
     
     \ /
      Last update: 2021-07-19 16:57    [W:2.639 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site