Messages in this thread Patch in this message | | | From | Kuppuswamy Sathyanarayanan <> | Subject | [PATCH v2 4/4] x86/tdx: Add tdg_debug_enabled() interface | Date | Mon, 19 Jul 2021 21:33:38 -0700 |
| |
A guest TD is defined as debuggable if its ATTRIBUTES.DEBUG bit is 1. In this mode, the host VMM can use Intel TDX functions to access secret TD state that is not accessible for non-debuggable TDs. A debuggable TD is, by nature, untrusted.
Since the TD’s ATTRIBUTES are included in the TDG.MR.REPORT, the TD’s debuggability state can be known to any third party to which the TD attests. TD Attributes are initialized during TD INIT call. You can get more details about debug features in Intel Trust Domain Extensions (Intel TDX) Module Architecture specification, sec 13.3.
Add a new interface to detect the TDX debug mode. This will be used by follow-on patches. Examples of its usage are, when adding command line debug options to disable TDX features like driver or port filter, tdg_debug_enabled() is used to make sure it is used only in debug mode.
https://software.intel.com/content/dam/develop/external/us/en/documents/tdx-module-1eas-v0.85.039.pdf
Reviewed-by: Tony Luck <tony.luck@intel.com> Reviewed-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> --- arch/x86/include/asm/tdx.h | 1 + arch/x86/kernel/tdx.c | 5 +++++ 2 files changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h index 665c8cf57d5b..1c0d4bf693a3 100644 --- a/arch/x86/include/asm/tdx.h +++ b/arch/x86/include/asm/tdx.h @@ -67,6 +67,7 @@ enum tdx_map_type { #ifdef CONFIG_INTEL_TDX_GUEST +bool tdg_debug_enabled(void); void __init tdx_early_init(void); bool tdx_prot_guest_has(unsigned long flag); diff --git a/arch/x86/kernel/tdx.c b/arch/x86/kernel/tdx.c index 9b0361218863..fcf2743481b7 100644 --- a/arch/x86/kernel/tdx.c +++ b/arch/x86/kernel/tdx.c @@ -123,6 +123,11 @@ phys_addr_t tdg_shared_mask(void) return 1ULL << (td_info.gpa_width - 1); } +bool tdg_debug_enabled(void) +{ + return td_info.attributes & BIT(0); +} + static void tdg_get_info(void) { u64 ret; -- 2.25.1
| |