Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH 3/7] EDAC/mc: Add new HBM2 memory type | Date | Mon, 19 Jul 2021 21:16:58 +0000 |
| |
> The following commit added HBM support to some Intel EDAC code. > > c945088384d0 EDAC/i10nm: Add support for high bandwidth memory > > But it didn't include a new mem_type for HBM. Should it have? > > I only see some edac_mem_types use in sysfs and some debug messages. So > I'm curious if users find this information useful.
Yazen,
That commit makes the normal vs. HBM error visible in the DIMM label (by prefixing the "MC" for memory controller with "HB".
+ if (imc->hbm_mc) + snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_HBMC#%u_Chan#%u", + imc->src_id, imc->lmc, chan); + else + snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", + imc->src_id, imc->lmc, chan, dimmno);
Perhaps we should also set the "type" of the DIMMs. Qiuxu: opinion?
-Tony
| |