Messages in this thread | | | Date | Mon, 19 Jul 2021 22:56:21 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v6] net: phy: intel-xway: Add RGMII internal delay configuration |
| |
> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || > + phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) { > + int_delay = phy_get_internal_delay(phydev, dev, > + xway_internal_delay, > + delay_size, true); > + > + if (int_delay < 0) { > + phydev_warn(phydev, "rx-internal-delay-ps is missing, use default of 2.0 ns\n"); > + int_delay = 4; /* 2000 ps */
The binding say:
rx-internal-delay-ps: description: | RGMII Receive PHY Clock Delay defined in pico seconds. This is used for PHY's that have configurable RX internal delays. If this property is present then the PHY applies the RX delay.
So the property is optional. It being missing should not generate a warning. Please just use the default of 2ns. This makes the usage the same as the other drivers using phy_get_internal_delay().
Andrew
| |