Messages in this thread | | | Subject | Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper | From | tianxianting <> | Date | Mon, 19 Jul 2021 12:22:44 +0800 |
| |
thanks,
I checked, actually all virtio drivers have switched to use the helper after this one merged.
在 2021/7/19 上午11:46, Jason Wang 写道: > > 在 2021/7/16 下午8:46, tianxianting 写道: >> Do you interest in this patch? just little improvment:) >> >> 在 2021/7/13 下午11:38, Xianting Tian 写道: >>> From: Xianting Tian <xianting.tian@linux.alibaba.com> >>> >>> Use the helper virtio_find_vqs(). >>> >>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> >>> --- >>> drivers/virtio/virtio_balloon.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/virtio/virtio_balloon.c >>> b/drivers/virtio/virtio_balloon.c >>> index 510e931..18e0bf3 100644 >>> --- a/drivers/virtio/virtio_balloon.c >>> +++ b/drivers/virtio/virtio_balloon.c >>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb) >>> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack; >>> } >>> - err = vb->vdev->config->find_vqs(vb->vdev, >>> VIRTIO_BALLOON_VQ_MAX, >>> - vqs, callbacks, names, NULL, NULL); >>> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs, >>> + callbacks, names, NULL); >>> if (err) >>> return err; >> > > Acked-by: Jason Wang <jasowang@redhat.com> > > Maybe it's better to convert all the drivers that doesn't use > virtio_find_vqs{_ctx}. > > Thanks
| |