lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 131/351] usb: gadget: f_hid: fix endianness issue with descriptors
    Date
    From: Ruslan Bilovol <ruslan.bilovol@gmail.com>

    [ Upstream commit 33cb46c4676d01956811b68a29157ea969a5df70 ]

    Running sparse checker it shows warning message about
    incorrect endianness used for descriptor initialization:

    | f_hid.c:91:43: warning: incorrect type in initializer (different base types)
    | f_hid.c:91:43: expected restricted __le16 [usertype] bcdHID
    | f_hid.c:91:43: got int

    Fixing issue with cpu_to_le16() macro, however this is not a real issue
    as the value is the same both endians.

    Cc: Fabien Chouteau <fabien.chouteau@barco.com>
    Cc: Segiy Stetsyuk <serg_stetsuk@ukr.net>
    Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
    Link: https://lore.kernel.org/r/20210617162755.29676-1-ruslan.bilovol@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/function/f_hid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
    index e55699308117..a82b3de1a54b 100644
    --- a/drivers/usb/gadget/function/f_hid.c
    +++ b/drivers/usb/gadget/function/f_hid.c
    @@ -88,7 +88,7 @@ static struct usb_interface_descriptor hidg_interface_desc = {
    static struct hid_descriptor hidg_desc = {
    .bLength = sizeof hidg_desc,
    .bDescriptorType = HID_DT_HID,
    - .bcdHID = 0x0101,
    + .bcdHID = cpu_to_le16(0x0101),
    .bCountryCode = 0x00,
    .bNumDescriptors = 0x1,
    /*.desc[0].bDescriptorType = DYNAMIC */
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 20:10    [W:2.488 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site