lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 041/351] dmaengine: fsl-qdma: check dma_set_mask return value
    Date
    From: Robin Gong <yibin.gong@nxp.com>

    [ Upstream commit f0c07993af0acf5545d5c1445798846565f4f147 ]

    For fix below warning reported by static code analysis tool like Coverity
    from Synopsys:

    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    Addresses-Coverity-ID: 12285639 ("Unchecked return value")
    Link: https://lore.kernel.org/r/1619427549-20498-1-git-send-email-yibin.gong@nxp.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/fsl-qdma.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
    index ed2ab46b15e7..045ead46ec8f 100644
    --- a/drivers/dma/fsl-qdma.c
    +++ b/drivers/dma/fsl-qdma.c
    @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev)
    fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize;
    fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all;

    - dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
    + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
    + if (ret) {
    + dev_err(&pdev->dev, "dma_set_mask failure.\n");
    + return ret;
    + }

    platform_set_drvdata(pdev, fsl_qdma);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 19:41    [W:4.072 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site