lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 068/351] scsi: lpfc: Fix crash when lpfc_sli4_hba_setup() fails to initialize the SGLs
    Date
    From: James Smart <jsmart2021@gmail.com>

    [ Upstream commit 5aa615d195f1e142c662cb2253f057c9baec7531 ]

    The driver is encountering a crash in lpfc_free_iocb_list() while
    performing initial attachment.

    Code review found this to be an errant failure path that was taken, jumping
    to a tag that then referenced structures that were uninitialized.

    Fix the failure path.

    Link: https://lore.kernel.org/r/20210514195559.119853-9-jsmart2021@gmail.com
    Co-developed-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: James Smart <jsmart2021@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/lpfc/lpfc_sli.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
    index bc0bcb0dccc9..9ed826fd53e8 100644
    --- a/drivers/scsi/lpfc/lpfc_sli.c
    +++ b/drivers/scsi/lpfc/lpfc_sli.c
    @@ -7959,7 +7959,7 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)
    "0393 Error %d during rpi post operation\n",
    rc);
    rc = -ENODEV;
    - goto out_destroy_queue;
    + goto out_free_iocblist;
    }
    lpfc_sli4_node_prep(phba);

    @@ -8125,8 +8125,9 @@ out_io_buff_free:
    out_unset_queue:
    /* Unset all the queues set up in this routine when error out */
    lpfc_sli4_queue_unset(phba);
    -out_destroy_queue:
    +out_free_iocblist:
    lpfc_free_iocb_list(phba);
    +out_destroy_queue:
    lpfc_sli4_queue_destroy(phba);
    out_stop_timers:
    lpfc_stop_hba_timers(phba);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 19:41    [W:4.071 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site