Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 19 Jul 2021 11:10:12 +0200 | Subject | Re: [PATCH v4 2/2] clk: Add ccf driver for Renesas 8T49N241 |
| |
Hi Alex,
On Tue, Jul 13, 2021 at 11:41 PM Alex Helms <alexander.helms.jy@renesas.com> wrote: > This is a common clock framework driver that supports the 8T49N241 chip. > No other chips in the family are currently supported. The driver > supports setting the rate for all four outputs on the chip and > automatically calculating/setting the appropriate VCO value. > > The driver can read a full register map from the device tree > and will use that register map to initialize the attached device > (via I2C) when the system boots. Any configuration not supported by > the common clock framework must be done via the full register map, > including optimized settings. > > All outputs are currently assumed to be LVDS unless overridden in > the full register map in the DT. > > Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
Thanks for your patch!
> Reported-by: kernel test robot <lkp@intel.com>
I don't think that line belongs here (lkp requesting 8T49N241 support? ;-)
> --- > MAINTAINERS | 1 + > drivers/clk/Kconfig | 21 + > drivers/clk/renesas/8t49n24x-core.c | 836 ++++++++++++++++++++++++++++ > drivers/clk/renesas/8t49n24x-core.h | 250 +++++++++ > drivers/clk/renesas/8t49n24x.c | 572 +++++++++++++++++++ > drivers/clk/renesas/Makefile | 4 + > 6 files changed, 1684 insertions(+) > create mode 100644 drivers/clk/renesas/8t49n24x-core.c > create mode 100644 drivers/clk/renesas/8t49n24x-core.h > create mode 100644 drivers/clk/renesas/8t49n24x.c
As this is a driver for a discrete part originally from IDT, not a clock generator integrated on a Renesas SoC, I think it belongs under drivers/clk/ instead of drivers/clk/renesas/. That would align nicely with the Kconfig symbol already residing in drivers/clk/Kconfig.
> --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15580,6 +15580,7 @@ M: Alex Helms <alexander.helms.jy@renesas.com> > M: David Cater <david.cater.jc@renesas.com> > S: Odd Fixes > F: Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml > +F: drivers/clk/renesas/8t49n24x* > > RENESAS CLOCK DRIVERS > M: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |