lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 063/149] ALSA: hda: Add IRQ check for platform_get_irq()
    Date
    From: Jiajun Cao <jjcao20@fudan.edu.cn>

    [ Upstream commit 8c13212443230d03ff25014514ec0d53498c0912 ]

    The function hda_tegra_first_init() neglects to check the return
    value after executing platform_get_irq().

    hda_tegra_first_init() should check the return value (if negative
    error number) for errors so as to not pass a negative value to
    the devm_request_irq().

    Fix it by adding a check for the return value irq_id.

    Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn>
    Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
    Reviewed-by: Thierry Reding <treding@nvidia.com>
    Link: https://lore.kernel.org/r/20210622131947.94346-1-jjcao20@fudan.edu.cn
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/hda_tegra.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
    index e378cb33c69d..2971b34c87c1 100644
    --- a/sound/pci/hda/hda_tegra.c
    +++ b/sound/pci/hda/hda_tegra.c
    @@ -292,6 +292,9 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
    const char *sname, *drv_name = "tegra-hda";
    struct device_node *np = pdev->dev.of_node;

    + if (irq_id < 0)
    + return irq_id;
    +
    err = hda_tegra_init_chip(chip, pdev);
    if (err)
    return err;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 19:11    [W:2.082 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site