lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 343/421] gpio: zynq: Check return value of pm_runtime_get_sync
    Date
    From: Srinivas Neeli <srinivas.neeli@xilinx.com>

    [ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ]

    Return value of "pm_runtime_get_sync" API was neither captured nor checked.
    Fixed it by capturing the return value and then checking for any warning.

    Addresses-Coverity: "check_return"
    Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/gpio-zynq.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
    index 5dec96155814..c2279b28bcb9 100644
    --- a/drivers/gpio/gpio-zynq.c
    +++ b/drivers/gpio/gpio-zynq.c
    @@ -919,8 +919,11 @@ err_pm_dis:
    static int zynq_gpio_remove(struct platform_device *pdev)
    {
    struct zynq_gpio *gpio = platform_get_drvdata(pdev);
    + int ret;

    - pm_runtime_get_sync(&pdev->dev);
    + ret = pm_runtime_get_sync(&pdev->dev);
    + if (ret < 0)
    + dev_warn(&pdev->dev, "pm_runtime_get_sync() Failed\n");
    gpiochip_remove(&gpio->chip);
    clk_disable_unprepare(gpio->clk);
    device_set_wakeup_capable(&pdev->dev, 0);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 19:11    [W:4.028 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site