Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH] f2fs: let's keep writing IOs on SBI_NEED_FSCK | From | Chao Yu <> | Date | Mon, 19 Jul 2021 16:23:34 +0800 |
| |
On 2021/7/15 7:18, Jaegeuk Kim wrote: > SBI_NEED_FSCK is an indicator that fsck.f2fs needs to be triggered, so it > is not fully critical to stop any IO writes. So, let's allow to write data > instead of reporting EIO forever given SBI_NEED_FSCK.
Well, it looks we need to check why there is SBI_NEED_FSCK flag.
If this patch breaks something, how about forcing OPU if SBI_NEED_FSCK was set?
> > Fixes: 955772787667 ("f2fs: drop inplace IO if fs status is abnormal") > Cc: <stable@kernel.org> # v5.13+ > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 15cc89eef28d..f9b7fb785e1d 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -3563,7 +3563,7 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio) > goto drop_bio; > } > > - if (is_sbi_flag_set(sbi, SBI_NEED_FSCK) || f2fs_cp_error(sbi)) { > + if (f2fs_cp_error(sbi)) { > err = -EIO; > goto drop_bio; > } >
| |