lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 251/421] net: micrel: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 20f1932e2282c58cb5ac59517585206cf5b385ae ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/micrel/ks8842.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c
    index e3d7c74d47bb..5282c5754ac1 100644
    --- a/drivers/net/ethernet/micrel/ks8842.c
    +++ b/drivers/net/ethernet/micrel/ks8842.c
    @@ -1150,6 +1150,10 @@ static int ks8842_probe(struct platform_device *pdev)
    unsigned i;

    iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!iomem) {
    + dev_err(&pdev->dev, "Invalid resource\n");
    + return -EINVAL;
    + }
    if (!request_mem_region(iomem->start, resource_size(iomem), DRV_NAME))
    goto err_mem_region;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 18:24    [W:2.368 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site