lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 127/421] wireless: carl9170: fix LEDS build errors & warnings
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 272fdc0c4542fad173b44965be02a16d6db95499 ]

    kernel test robot reports over 200 build errors and warnings
    that are due to this Kconfig problem when CARL9170=m,
    MAC80211=y, and LEDS_CLASS=m.

    WARNING: unmet direct dependencies detected for MAC80211_LEDS
    Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
    Selected by [m]:
    - CARL9170_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && CARL9170 [=m]

    CARL9170_LEDS selects MAC80211_LEDS even though its kconfig
    dependencies are not met. This happens because 'select' does not follow
    any Kconfig dependency chains.

    Fix this by making CARL9170_LEDS depend on MAC80211_LEDS, where
    the latter supplies any needed dependencies on LEDS_CLASS.

    Fixes: 1d7e1e6b1b8ed ("carl9170: Makefile, Kconfig files and MAINTAINERS")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Reported-by: kernel test robot <lkp@intel.com>
    Cc: Kalle Valo <kvalo@codeaurora.org>
    Cc: Christian Lamparter <chunkeey@googlemail.com>
    Cc: linux-wireless@vger.kernel.org
    Cc: Arnd Bergmann <arnd@arndb.de>
    Suggested-by: Christian Lamparter <chunkeey@googlemail.com>
    Acked-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Christian Lamparter <chunkeey@gmail.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20210530031134.23274-1-rdunlap@infradead.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/carl9170/Kconfig | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig
    index 2e34baeaf764..2b782db20fde 100644
    --- a/drivers/net/wireless/ath/carl9170/Kconfig
    +++ b/drivers/net/wireless/ath/carl9170/Kconfig
    @@ -15,13 +15,11 @@ config CARL9170

    config CARL9170_LEDS
    bool "SoftLED Support"
    - depends on CARL9170
    - select MAC80211_LEDS
    - select LEDS_CLASS
    - select NEW_LEDS
    default y
    + depends on CARL9170
    + depends on MAC80211_LEDS
    help
    - This option is necessary, if you want your device' LEDs to blink
    + This option is necessary, if you want your device's LEDs to blink.

    Say Y, unless you need the LEDs for firmware debugging.

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 18:11    [W:2.532 / U:1.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site