lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 083/315] pata_ep93xx: fix deferred probing
    Date
    From: Sergey Shtylyov <s.shtylyov@omprussia.ru>

    [ Upstream commit 5c8121262484d99bffb598f39a0df445cecd8efb ]

    The driver overrides the error codes returned by platform_get_irq() to
    -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
    permanently instead of the deferred probing. Propagate the error code
    upstream, as it should have been done from the start...

    Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
    Link: https://lore.kernel.org/r/509fda88-2e0d-2cc7-f411-695d7e94b136@omprussia.ru
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ata/pata_ep93xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
    index cc6d06c1b2c7..7ce62cdb63a5 100644
    --- a/drivers/ata/pata_ep93xx.c
    +++ b/drivers/ata/pata_ep93xx.c
    @@ -927,7 +927,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev)
    /* INT[3] (IRQ_EP93XX_EXT3) line connected as pull down */
    irq = platform_get_irq(pdev, 0);
    if (irq < 0) {
    - err = -ENXIO;
    + err = irq;
    goto err_rel_gpio;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 18:10    [W:8.533 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site