lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 225/315] media: gspca/sq905: fix control-request direction
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 53ae298fde7adcc4b1432bce2dbdf8dac54dfa72 upstream.

    The direction of the pipe argument must match the request-type direction
    bit or control requests may fail depending on the host-controller-driver
    implementation.

    Fix the USB_REQ_SYNCH_FRAME request which erroneously used
    usb_sndctrlpipe().

    Fixes: 27d35fc3fb06 ("V4L/DVB (10639): gspca - sq905: New subdriver.")
    Cc: stable@vger.kernel.org # 2.6.30
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/usb/gspca/sq905.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/usb/gspca/sq905.c
    +++ b/drivers/media/usb/gspca/sq905.c
    @@ -125,7 +125,7 @@ static int sq905_command(struct gspca_de
    }

    ret = usb_control_msg(gspca_dev->dev,
    - usb_sndctrlpipe(gspca_dev->dev, 0),
    + usb_rcvctrlpipe(gspca_dev->dev, 0),
    USB_REQ_SYNCH_FRAME, /* request */
    USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
    SQ905_PING, 0, gspca_dev->usb_buf, 1,

    \
     
     \ /
      Last update: 2021-07-19 18:10    [W:4.118 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site