lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 102/421] crypto: ccp - Fix a resource leak in an error handling path
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit a6f8e68e238a15bb15f1726b35c695136c64eaba ]

    If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be
    called as already done in the error handling path.

    Fixes: f4d18d656f88 ("crypto: ccp - Abstract interrupt registeration")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Acked-by: John Allen <john.allen@amd.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/ccp/sp-pci.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
    index 7da93e9bebed..9b2742212ea8 100644
    --- a/drivers/crypto/ccp/sp-pci.c
    +++ b/drivers/crypto/ccp/sp-pci.c
    @@ -216,7 +216,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
    if (ret) {
    dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n",
    ret);
    - goto e_err;
    + goto free_irqs;
    }
    }

    @@ -224,12 +224,14 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)

    ret = sp_init(sp);
    if (ret)
    - goto e_err;
    + goto free_irqs;

    dev_notice(dev, "enabled\n");

    return 0;

    +free_irqs:
    + sp_free_irqs(sp);
    e_err:
    dev_notice(dev, "initialization failed\n");
    return ret;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-19 18:10    [W:4.235 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site