lkml.org 
[lkml]   [2021]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V6 1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML
Date
On Mon, 19 Jul 2021 16:37:34 +0530, satya priya wrote:
> Convert Qualcomm PMIC GPIO bindings from .txt to .yaml format.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changes in V2:
> - As per Rob's comments fixed bot erros.
> - Moved this patch to end of the series so that other patches are not
> blocked on this.
>
> Changes in V3:
> - As per Rob's comments, added maxItems for reg and interrupts.
> Added reference of "pinmux-node.yaml" and "pincfg-node.yaml".
> Made 'additionalProperties' as false.
>
> Changes in V4:
> - As per Rob's comments, added description for interrupts, defined
> constraints for "qcom,drive-strength", dropped description for function
> property.
>
> Changes in RESEND V4:
> - Rebased on linux-next and sent.
>
> Changes in V5:
> - Fixed Bjorn's comments on [1]
>
> [1] https://lore.kernel.org/patchwork/patch/1434144/
>
> Changes in V6:
> - As per Bjorn's comments, removed formatting for description, changed
> node name to be more specific to qcom pmic, and fixed few other minor
> things as suggested here [2].
>
> [2] https://lore.kernel.org/patchwork/patch/1452812/#1654560
>
> .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 288 ---------------------
> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 259 ++++++++++++++++++
> 2 files changed, 259 insertions(+), 288 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: gpio@c000: compatible: ['qcom,pm8008-gpio'] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: gpio@c000: 'gpio-ranges' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
\ndoc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1506906

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

\
 
 \ /
  Last update: 2021-07-19 18:10    [W:0.041 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site