lkml.org 
[lkml]   [2021]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH AUTOSEL 4.19 05/39] scsi: hisi_sas: Propagate errors in interrupt_init_v1_hw()
From
Date
Hello!

On 18.07.2021 4:20, Sasha Levin wrote:

[...]
>>> [ Upstream commit ab17122e758ef68fb21033e25c041144067975f5 ]
>>>
>>> After commit 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks") we have the
>>> error codes returned by platform_get_irq() ready for the propagation
>>> upsream in interrupt_init_v1_hw() -- that will fix still broken deferred
>>> probing. Let's propagate the error codes from devm_request_irq() as well
>>> since I don't see the reason to override them with -ENOENT...
>>>
>>> Link: https://lore.kernel.org/r/49ba93a3-d427-7542-d85a-b74fe1a33a73@omp.ru
>>> Acked-by: John Garry <john.garry@huawei.com>
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>>> ---
>>>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>>> b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>>> index 8aa3222fe486..5a777e48963b 100644
>>> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>>> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
>> [...]
>>> @@ -1717,7 +1717,7 @@ static int interrupt_init_v1_hw(struct hisi_hba
>>> *hisi_hba)
>>>          if (!irq) {
>>>              dev_err(dev, "irq init: could not map cq interrupt %d\n",
>>>                  idx);
>>> -            return -ENOENT;
>>> +            return irq;
>>
>>   This patch is borked too, we don't want to return 0 here...
>
> Looks like it's broken on <=4.19, I'll drop it. Thanks!

You might to want backport the below patch (before this one),
the same way yoo did for 5.x-stable):

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6c11dc060427e07ca144eacaccd696106b361b06

MBR, Sergei

\
 
 \ /
  Last update: 2021-07-18 11:15    [W:0.123 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site