Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 18 Jul 2021 02:16:53 +0200 | Subject | Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings |
| |
Hi Dillon,
thanks for your patch!
On Fri, Jul 16, 2021 at 12:20 PM <dillon.minfei@gmail.com> wrote:
> From: Dillon Min <dillon.minfei@gmail.com> > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX)
This is a DBI feature so mention in the description that this is a DBI panel.
> + spi-3wire: true > + > + spi-max-frequency: > + const: 10000000 > + > + port: true > + > +additionalProperties: false
Please add regulator supplies for the power lines, it's fine not to implement code handling them in the driver but they should be in the bindings.
For the ili9341 it should be
vci-supply: description: Analog voltage supply (2.5 .. 3.3V)
vddi-supply: description: Voltage supply for interface logic (1.65 .. 3.3 V)
vddi-led-supply: description: Voltage supply for the LED driver (1.65 .. 3.3 V)
Yours, Linus Walleij
| |