lkml.org 
[lkml]   [2021]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of charger state
From
Date
17.07.2021 19:20, Sebastian Reichel пишет:
> Hi,
>
> On Sat, Jul 17, 2021 at 03:11:08PM +0300, Dmitry Osipenko wrote:
>> Regmap already provides us with the caching, so remove caching of charger
>> state to make code cleaner.
>
> cache_type is not initialized in smb347's regmap config and thus
> set to 0 = REGCACHE_NONE:
>
> static const struct regmap_config smb347_regmap = {
> .reg_bits = 8,
> .val_bits = 8,
> .max_register = SMB347_MAX_REGISTER,
> .volatile_reg = smb347_volatile_reg,
> .readable_reg = smb347_readable_reg,
> };

Good catch, thank you. I'll add patch to enable caching.

\
 
 \ /
  Last update: 2021-07-17 19:30    [W:0.044 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site