lkml.org 
[lkml]   [2021]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] arm64: dts: sc7180: Add required-opps for i2c
On Fri 16 Jul 05:00 CDT 2021, Rajendra Nayak wrote:

> qup-i2c devices on sc7180 are clocked with a fixed clock (19.2 MHz)
> Though qup-i2c does not support DVFS, it still needs to vote for a
> performance state on 'CX' to satisfy the 19.2 Mhz clock frequency
> requirement.
>

Sounds good, but...

> Use 'required-opps' to pass this information from
> device tree, and also add the power-domains property to specify
> the CX power-domain.
>

..is the required-opps really needed with my rpmhpd patch in place?

Regards,
Bjorn

> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index a5d58eb..cd30185 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -785,8 +785,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>,
> <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi0: spi@880000 {
> @@ -837,8 +839,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>,
> <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi1: spi@884000 {
> @@ -889,8 +893,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>,
> <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> uart2: serial@888000 {
> @@ -923,8 +929,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>,
> <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi3: spi@88c000 {
> @@ -975,8 +983,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>,
> <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> uart4: serial@890000 {
> @@ -1009,8 +1019,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_0 0>,
> <&aggre1_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi5: spi@894000 {
> @@ -1074,8 +1086,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>,
> <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi6: spi@a80000 {
> @@ -1126,8 +1140,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>,
> <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> uart7: serial@a84000 {
> @@ -1160,8 +1176,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>,
> <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi8: spi@a88000 {
> @@ -1212,8 +1230,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>,
> <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> uart9: serial@a8c000 {
> @@ -1246,8 +1266,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>,
> <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi10: spi@a90000 {
> @@ -1298,8 +1320,10 @@
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>,
> <&aggre2_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI1 0>;
> interconnect-names = "qup-core", "qup-config",
> "qup-memory";
> + power-domains = <&rpmhpd SC7180_CX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> status = "disabled";
> };
>
> spi11: spi@a94000 {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

\
 
 \ /
  Last update: 2021-07-16 22:19    [W:0.123 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site