lkml.org 
[lkml]   [2021]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend] Input: adc-keys - drop bogus __refdata annotation
On 14/07/2021 11:38:33+0200, Geert Uytterhoeven wrote:
> As the ADC ladder input driver does not have any code or data located in
> initmem, there is no need to annotate the adc_keys_driver structure with
> __refdata. Drop the annotation, to avoid suppressing future section
> warnings.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

I must admit I can't remember why I used that annotation...

> ---
> drivers/input/keyboard/adc-keys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/adc-keys.c b/drivers/input/keyboard/adc-keys.c
> index 6d5be48d1b3d7988..bf72ab8df817756f 100644
> --- a/drivers/input/keyboard/adc-keys.c
> +++ b/drivers/input/keyboard/adc-keys.c
> @@ -193,7 +193,7 @@ static const struct of_device_id adc_keys_of_match[] = {
> MODULE_DEVICE_TABLE(of, adc_keys_of_match);
> #endif
>
> -static struct platform_driver __refdata adc_keys_driver = {
> +static struct platform_driver adc_keys_driver = {
> .driver = {
> .name = "adc_keys",
> .of_match_table = of_match_ptr(adc_keys_of_match),
> --
> 2.25.1
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2021-07-16 18:51    [W:0.041 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site