Messages in this thread | | | Subject | Re: [PATCH Part2 RFC v4 15/40] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled | From | Brijesh Singh <> | Date | Fri, 16 Jul 2021 10:47:32 -0500 |
| |
On 7/16/21 10:35 AM, Sean Christopherson wrote: > It wasn't comment on the patch organization, rather that the code added in patch 14 > appears to have landed in the wrong location within the code. The above diff shows > that the TMR allocation is being moved around the SNP initialization code that was > added in patch 14 (the immediately prior patch). Presumably the required order > doesn't magically change just because the TMR is now being allocated as a 2mb blob, > so either the code movement is unnecessary churn or the original location was wrong. > In either case, landing the SNP initialization code above the TMR allocation in > patch 14 would eliminate the above code movement.
Got it, I'll rearrange things in the previous patch to avoid this hunk.
thanks
| |