Messages in this thread | | | Subject | Re: [PATCH 3/3] mm/vmstat: remove unneeded return value | From | David Hildenbrand <> | Date | Fri, 16 Jul 2021 14:59:14 +0200 |
| |
On 15.07.21 14:29, Miaohe Lin wrote: > The return value of pagetypeinfo_showfree and pagetypeinfo_showblockcount > are unused now. Remove them. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/vmstat.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 76aef9510f6d..6246bab9fae2 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1452,7 +1452,7 @@ static void pagetypeinfo_showfree_print(struct seq_file *m, > } > > /* Print out the free pages at each order for each migatetype */ > -static int pagetypeinfo_showfree(struct seq_file *m, void *arg) > +static void pagetypeinfo_showfree(struct seq_file *m, void *arg) > { > int order; > pg_data_t *pgdat = (pg_data_t *)arg; > @@ -1464,8 +1464,6 @@ static int pagetypeinfo_showfree(struct seq_file *m, void *arg) > seq_putc(m, '\n'); > > walk_zones_in_node(m, pgdat, true, false, pagetypeinfo_showfree_print); > - > - return 0; > } > > static void pagetypeinfo_showblockcount_print(struct seq_file *m, > @@ -1501,7 +1499,7 @@ static void pagetypeinfo_showblockcount_print(struct seq_file *m, > } > > /* Print out the number of pageblocks for each migratetype */ > -static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > +static void pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > { > int mtype; > pg_data_t *pgdat = (pg_data_t *)arg; > @@ -1512,8 +1510,6 @@ static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > seq_putc(m, '\n'); > walk_zones_in_node(m, pgdat, true, false, > pagetypeinfo_showblockcount_print); > - > - return 0; > } > > /* >
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |