Messages in this thread | | | Subject | Re: [PATCH V5 1/1] misc: NOC Probe Counters | From | Georgi Djakov <> | Date | Fri, 16 Jul 2021 15:33:41 +0300 |
| |
Hi Pandith,
On 13.07.21 10:22, Arnd Bergmann wrote: > On Tue, Jul 13, 2021 at 8:54 AM <pandith.n@intel.com> wrote: >> >> From: Pandith N <pandith.n@intel.com> >> >> Add support for Network on Chip(NOC) counters. Enable features to configure >> and capture NOC probe counters, needed for DDR bandwidth measurement. NOC >> driver is specific to Intel Keem Bay SOC. NOC hardware counters are used >> for DDR statistics profiling, it is not related to timers. >> Interface details are provided in include/uapi/linux/noc_uapi.h >> >> Signed-off-by: Pandith N <pandith.n@intel.com> >> Reviewed-by: Mark Gross <mgross@linux.intel.com> > > I'm missing some explanation here regarding why this is not part of > drivers/interconnect/. > > I assume you have discussed this with Georgi Djakov before, but if not, then > please do. From a very high-level perspective, I would have guessed that this > would be part of the interconnect framework, with any user facing setup being > either derived from the DT, or exposed through debugfs.
Thank you for the patch! We already have several drivers that support some NXP and Qualcomm Network-On-Chip hardware, that is also based on FlexNoC. I suspect that they also may support counters, but nobody added that support yet. So maybe it makes sense to have this in drivers/interconnect/.
I am wondering what is the plan for this. Who will be using the info from this counters - is it some driver or tool? Who and how will use the statistics? We already have some debugfs interface that shows the current bandwidth thats being requested by users on the several ports. Maybe we could add also information about measured bandwidth? Before doing a detailed review on the patch, i would like to learn more about how this and is there any specific reason for choosing ioctl interface for this? Thanks!
> > (full quote below for Georgi, no further comments there)
Thank you Arnd!
BR, Georgi
| |