lkml.org 
[lkml]   [2021]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: submit.c:27:17: error: expected ')' before '__VA_OPT__' current->comm __VA_OPT__(,) __VA_ARGS__)
From
Date

On 15/07/2021 19:36, Naresh Kamboju wrote:
> Regression detected on Linux next tag 20210715 for arm64 due to the
> following patch with
> - gcc-7 - FAILED
> - clang-10 - FAILED
> - clang-11- FAILED
> But PASS with gcc-11 and clang-12
>
> drm/tegra: Implement job submission part of new UAPI
> Implement the job submission IOCTL with a minimum feature set.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>
> Build error:
> ------------
> CC [M] drivers/gpu/drm/tegra/submit.o
> In file included include/linux/device.h:15:0,
> include/linux/host1x.h:9,
> drivers/gpu/drm/tegra/submit.c:6:
> drivers/gpu/drm/tegra/submit.c: In function 'submit_copy_gather_data':
> drivers/gpu/drm/tegra/submit.c:27:17: error: expected ')' before '__VA_OPT__'
> current->comm __VA_OPT__(,) __VA_ARGS__)
> ^
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> ref:
> https://gitlab.com/Linaro/lkft/mirrors/next/linux-next/-/jobs/1425953551#L197
>
> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-next/DISTRO=lkft,MACHINE=juno,label=docker-buster-lkft/1068/consoleText


Thanks, yes I am seeing the same. The following fixes this and I will
send a patch to get this corrected.

diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
index c53b7207c478..e49630089149 100644
--- a/drivers/gpu/drm/tegra/submit.c
+++ b/drivers/gpu/drm/tegra/submit.c
@@ -24,7 +24,7 @@
#define SUBMIT_ERR(context, fmt, ...) \
dev_err_ratelimited(context->client->base.dev, \
"%s: job submission failed: " fmt "\n", \
- current->comm __VA_OPT__(,) __VA_ARGS__)
+ current->comm, ##__VA_ARGS__)

static struct tegra_drm_mapping *
tegra_drm_mapping_get(struct tegra_drm_context *context, u32 id)

Cheers
Jon

--
nvpublic

\
 
 \ /
  Last update: 2021-07-16 12:47    [W:0.048 / U:1.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site