Messages in this thread | | | From | Bin Meng <> | Date | Fri, 16 Jul 2021 18:44:14 +0800 | Subject | Re: [PATCH] riscv: add correct as-options for assembly in modules |
| |
On Tue, Jul 13, 2021 at 2:28 AM Ben Dooks <ben.dooks@codethink.co.uk> wrote: > > When trying to load modules built for riscv which include assembly
nits: RISC-V
> the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'" > due to R_RISCV_ALIGN relocations being generated by the assembler. > > In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") > the fix for gcc adds -mno-relax to the command line when building > C files. However this was never applied to assembly flags, and gcc > does no pass -mno-relax to gas when presented with a .S file.
does not pass
FYI
The GCC bug was fixed recently via: https://github.com/gcc-mirror/gcc/commit/3b0a7d624e64eeb81e4d5e8c62c46d86ef521857
> > The fix (other than making gcc always pass -mno-relax to gas) is > to add -Wa,-mno-relax to gcc to make sure the as is invoked with > the right options. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/riscv/Makefile | 1 + > 1 file changed, 1 insertion(+) >
Otherwise, Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
| |