Messages in this thread | | | From | Bin Meng <> | Date | Fri, 16 Jul 2021 18:14:13 +0800 | Subject | Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node |
| |
Hi Geert,
On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Bing, > > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > > > U-Boot expects this alias to be in place in order to fix up the mac > > address of the ethernet node. > > > > Note on the Icicle Kit board, currently only emac1 is enabled so it > > becomes the 'ethernet0'. > > > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > > Thanks for your patch!
Thanks for the review!
> > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > @@ -9,6 +9,10 @@ / { > > model = "Microchip MPFS Icicle Kit"; > > compatible = "microchip,mpfs-icicle-kit"; > > > > + aliases { > > + ethernet0 = &emac1; > > + }; > > + > > chosen { > > }; > > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts) > instead.
I was wondering the same thing before doing this, but when I checked all other DTS in arch/riscv/boot I found the aliases node is put in the SoC dtsi file instead of the board on so I think that's the convention.
Regards, Bin
| |