lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 015/122] drm/sched: Avoid data corruptions
    Date
    From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>

    [ Upstream commit 0b10ab80695d61422337ede6ff496552d8ace99d ]

    Wait for all dependencies of a job to complete before
    killing it to avoid data corruptions.

    Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210519141407.88444-1-andrey.grodzovsky@amd.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/scheduler/sched_entity.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
    index 1a5153197fe9..57f9baad9e36 100644
    --- a/drivers/gpu/drm/scheduler/sched_entity.c
    +++ b/drivers/gpu/drm/scheduler/sched_entity.c
    @@ -235,11 +235,16 @@ static void drm_sched_entity_kill_jobs_cb(struct dma_fence *f,
    static void drm_sched_entity_kill_jobs(struct drm_sched_entity *entity)
    {
    struct drm_sched_job *job;
    + struct dma_fence *f;
    int r;

    while ((job = to_drm_sched_job(spsc_queue_pop(&entity->job_queue)))) {
    struct drm_sched_fence *s_fence = job->s_fence;

    + /* Wait for all dependencies to avoid data corruptions */
    + while ((f = job->sched->ops->dependency(job, entity)))
    + dma_fence_wait(f, false);
    +
    drm_sched_fence_scheduled(s_fence);
    dma_fence_set_error(&s_fence->finished, -ESRCH);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-15 20:42    [W:4.157 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site