lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] net: ipv6: remove unused local variable
Date
On Thu, 2021-07-15 at 08:16 -0600, David Ahern wrote:
> On 7/14/21 10:20 PM, Rocco Yue wrote:
>> The local variable "struct net *net" in the two functions of
>> inet6_rtm_getaddr() and inet6_dump_addr() are actually useless,
>> so remove them.
>>
>> Signed-off-by: Rocco Yue <rocco.yue@mediatek.com>
>> ---
>> net/ipv6/addrconf.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>
> a v2 with no changelog. From what I can tell the only difference is
> "net: " in the Subject line which is not what I said in the last email.
>
> Let me try again: There are 2 trees - net for bug fixes and net-next for
> development (anything that is not a bug fix). Each patch should specify
> which tree the patch is for by putting 'net' or 'net-next' in the
> brackets ([]). This is a cleanup not a bug fix, so this patch should be:
>
> [PATCH net-next] ipv6: remove unused local variable
>
> and really that should be
>
> [PATCH net-next] ipv6: remove unnecessary local variable
>
> If you send more versions of a patch always put a changelog - a summary
> of what is different in the current patch versus the previous ones.
>
> No need to send another version of this patch unless you get a comment
> requesting change, or the maintainers ask for a re-send.
>
> Reviewed-by: David Ahern <dsahern@kernel.org>

Hi David,

Thanks for your detailed explanation,
I am appreciated that you shared these valureable advices for me.
They are important for my furture upstream work.
I will re-send it :)

Sincerely,
Rocco

\
 
 \ /
  Last update: 2021-07-15 16:36    [W:0.029 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site