Messages in this thread | | | Date | Thu, 15 Jul 2021 14:38:23 +0100 | From | Cristian Marussi <> | Subject | Re: [PATCH 10/13] mailbox: pcc: Avoid accessing PCCT table in pcc_send_data and pcc_mbox_irq |
| |
On Thu, Jul 08, 2021 at 07:08:48PM +0100, Sudeep Holla wrote: > Now that the con_priv is availvale solely for PCC mailbox controller > driver, let us use the same to save the channel specific information > in it so that we can it whenever required instead of parsing the PCCT > table entries every time in both pcc_send_data and pcc_mbox_irq. > > We can now use the newly introduces PCC register bundle to simplify both > saving of channel specific information and accessing them without repeated > checks for the subspace type. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > ---o [snip] >
Sorry missed this small doxygen break along the way early:
> /** > @@ -516,19 +457,20 @@ static int pcc_parse_subspace_irq(struct pcc_chan_info *pchan, > * @pcct_entry: Pointer to the ACPI subtable header. > * > */ > -static void pcc_parse_subspace_db_reg(struct pcc_chan_info *pchan, > - struct acpi_subtable_header *pcct_entry) > +static int pcc_parse_subspace_db_reg(struct pcc_chan_info *pchan, > + struct acpi_subtable_header *pcct_entry) > { > + int ret = 0; > +
drivers/mailbox/pcc.c:485: warning: No description found for return value of 'pcc_parse_subspace_db_reg'
Thanks, Cristian
| |