lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 4.19 35/55] net: fix mistake path for netdev_features_strings
Hi!

> From: Jian Shen <shenjian15@huawei.com>
>
> [ Upstream commit 2d8ea148e553e1dd4e80a87741abdfb229e2b323 ]
>
> Th_strings arrays netdev_features_strings, tunable_strings, and
> phy_tunable_strings has been moved to file net/ethtool/common.c.
> So fixes the comment.

This patch is incorrect for 4.19, as is still uses original filename,
not "net/ethtool/common.c".

[Plus it really should not be suitable for any stable release according
to our rules.]

Best regards,
Pavel

> +++ b/include/linux/netdev_features.h
> @@ -88,7 +88,7 @@ enum {
>
> /*
> * Add your fresh new feature above and remember to update
> - * netdev_features_strings[] in net/core/ethtool.c and maybe
> + * netdev_features_strings[] in net/ethtool/common.c and maybe
> * some feature mask #defines below. Please also describe it
> * in Documentation/networking/netdev-features.txt.
> */

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-07-15 10:46    [W:0.201 / U:4.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site