Messages in this thread Patch in this message | | | From | menglong8.dong@gmail ... | Subject | [PATCH linux-next] net:stmmac: Fix the unsigned expression compared with zero | Date | Thu, 15 Jul 2021 00:45:39 -0700 |
| |
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
WARNING: Unsigned expression "queue" compared with zero. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 7b8404a21544..a4cf2c640531 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1699,7 +1699,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) return 0; err_init_rx_buffers: - while (queue >= 0) { + do { struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; if (rx_q->xsk_pool) @@ -1710,11 +1710,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) rx_q->buf_alloc_num = 0; rx_q->xsk_pool = NULL; - if (queue == 0) - break; - - queue--; - } + } while (queue--); return ret; } -- 2.25.1
| |