Messages in this thread | | | Date | Thu, 15 Jul 2021 08:36:34 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 4/4] Revert "mm/page_alloc: make should_fail_alloc_page() static" |
| |
On Thu, Jul 15, 2021 at 07:34:53AM +0100, Christoph Hellwig wrote: > On Tue, Jul 13, 2021 at 02:56:25PM +0100, Mel Gorman wrote: > > From: Matteo Croce <mcroce@microsoft.com> > > > > This reverts commit f7173090033c70886d925995e9dfdfb76dbb2441. > > > > Fix an unresolved symbol error when CONFIG_DEBUG_INFO_BTF=y: > > I still fundamentally disagreed with this "fix". Whatever code requires > a function to be non-static without a prototype and reference is > completely fucked up beyond rescue and needs to be disabled util > it can be fixed instead of worked around like this.
I'm definitely not happy with the fix but the breakage was unintentional and given that it was done for a W=1 warning, the patch was low priority and I felt that users that do error injection to stress failure paths at least had some value. If I was fixing something important, I would feel differently and we've slammed patches before that fixed warnings while introducing worse problems. I'm still hoping that BTF gets fixed because it's the right thing to do.
-- Mel Gorman SUSE Labs
| |