Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH RFC 10/13] usb: gadget: simplify the printing with '%pD' specifier | Date | Thu, 15 Jul 2021 10:26:29 +0300 |
| |
Jia He <justin.he@arm.com> writes:
> After the behavior of '%pD' is changed to print the full path of file, > the log printing in fsg_common_create_lun() can be simplified. > > Given the space with proper length would be allocated in vprintk_store(), > it is worthy of dropping kmalloc()/kfree() to avoid additional space > allocation. The error case is well handled in d_path_unsafe(), the error > string would be copied in '%pD' buffer, no need to additionally handle > IS_ERR(). > > Cc: Felipe Balbi <balbi@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Chen Lin <chen.lin5@zte.com.cn> > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Jia He <justin.he@arm.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
-- balbi [unhandled content-type:application/pgp-signature] | |