Messages in this thread | | | Date | Thu, 15 Jul 2021 08:16:59 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 2/6] block: move disk announce work from register_disk() to a helper |
| |
On Thu, Jul 15, 2021 at 08:05:41AM +0100, Christoph Hellwig wrote: > On Wed, Jul 14, 2021 at 09:55:27PM -0700, Luis Chamberlain wrote: > > This moves quite a bit of code which does one thing into a helper. > > We currently do not check for errors but we may decide that might > > be desirable later. > > > > This also makes the code easier to read. > > > > This change has no functional changes. > > On it's own I don't really see the point of moving two function > calls and a comment into a separate helper, but I'll see where this > series goes..
Looking at the whole context I still can't see a good reason for this helper.
| |