Messages in this thread Patch in this message | | | From | Luis Chamberlain <> | Subject | [RFC 05/12] scsi/sd: add error handling support for add_disk() | Date | Thu, 15 Jul 2021 13:59:13 -0700 |
| |
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/scsi/sd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 6d0a82da7131..01af61a38e4e 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3489,7 +3489,11 @@ static int sd_probe(struct device *dev) pm_runtime_set_autosuspend_delay(dev, sdp->host->hostt->rpm_autosuspend_delay); } - device_add_disk(dev, gd, NULL); + + error = device_add_disk(dev, gd, NULL); + if (error) + goto out_free_index; + if (sdkp->capacity) sd_dif_config_host(sdkp); -- 2.27.0
| |