Messages in this thread Patch in this message | | | From | Luis Chamberlain <> | Subject | [RFC 3/6] md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken() | Date | Thu, 15 Jul 2021 13:23:38 -0700 |
| |
The GENHD_FL_DISK_ADDED flag is what we really want, as the flag GENHD_FL_UP could be set on a semi-initialized device.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/md/md.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md.h b/drivers/md/md.h index 832547cf038f..80561bca1f51 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -766,7 +766,7 @@ static inline bool is_mddev_broken(struct md_rdev *rdev, const char *md_type) { int flags = rdev->bdev->bd_disk->flags; - if (!(flags & GENHD_FL_UP)) { + if (!(flags & GENHD_FL_DISK_ADDED)) { if (!test_and_set_bit(MD_BROKEN, &rdev->mddev->flags)) pr_warn("md: %s: %s array has a missing/failed member\n", mdname(rdev->mddev), md_type); -- 2.27.0
| |